Fixes for Jsonnet global inventory and inventory dumping #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the YAML pretty printer was looking up an entry that didn't exist in the args cache during 'kapitan inventory'.
Normalise the type returned from the inventory native helper to avoid a Jsonnet failure, as the Pydantic types weren't able to be used by it. Also touch up some type handling to hopefully help avoid a repeat of this issue.
ademariag
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a couple of fixes for an issue we encountered when testing the current version on
masteragainst our inventories, which useinventory_global. This also adds a missing arg for thekapitan inventorycommand that I encountered while debugging the global inventory issue. I've also included a few changes to the types to make things a little clearer for other contributors and Pylance/IDE type checking.blackseems to have made quite a few formatting changes during pre-commit, which I'm happy to back out if we don't want those!Proposed Changes
--yaml-dump-null-as-emptyflag tokapitan inventory(required by the YAML dumper)Docs and Tests